Skip to content

Conversation

@namsonx
Copy link
Collaborator

@namsonx namsonx commented May 22, 2025

This pull-request for the Sprint-25.4.1

Copy link
Collaborator

@HolQue HolQue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording to be improved.

@HolQue
Copy link
Collaborator

HolQue commented May 22, 2025

Hi Son,

the error message:

'Invalid syntax! Please check the sub-element syntax of [1]{}['B'] in the key ${params}[1]{}['B'][0]['J']['026'][1]['028'][0].'

has been changed to:

'Invalid syntax: '${params}[1]{}['B'][0]['J']['026'][1]['028'][0]"' - The curly brackets are mismatch.'

The problem here is: There is no mismatch, but a pair of empty brackets at an invalid position. Therefore the new error message is misleading, but the previous error message was completely fine. Is it possible to restore the previous message in such cases?

@HolQue
Copy link
Collaborator

HolQue commented May 22, 2025

Hi Son,

it might be challenging for the JsonPreprocessor to react on this (invalid) code:

"params" : [
              11,
              ${"A" : 12,
               "B" : [
                     ...

In the past he did the job very well:

'Expecting ',' delimiter: line 5 column 23 (char 158)
Nearby: '... " : [\n                  11,\n                  "${"A""  : 12,\n          ...''

This error message has been changed to:

'Empty key name detected. Please enter a valid name.'

As user I would be lost now. No change to find the position that caused the error.

Is it possible to restore the previous error message?

@HolQue
Copy link
Collaborator

HolQue commented May 22, 2025

Hi Son,

previously:

'Slicing is not supported (expression: '${params}[:1]['B'][0]['C']').'

Now:

'Invalid syntax: ${params}[:1]['B'][0]['C']'

In my opinion the first error message is more meaningful.

Copy link
Owner

@test-fullautomation test-fullautomation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Son,
looks good to me!
Thank you,
Thomas

Copy link
Collaborator

@HolQue HolQue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed wording fine to me now

@github-project-automation github-project-automation bot moved this from Open to In Progress in RobotFramework AIO May 22, 2025
@test-fullautomation test-fullautomation merged commit d5d258f into develop May 22, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in RobotFramework AIO May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.14.1 enhancement New feature or request

Projects

Development

Successfully merging this pull request may close these issues.

4 participants