-
Notifications
You must be signed in to change notification settings - Fork 2
Namsonx/task/stabi branch #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wording to be improved.
|
Hi Son, the error message:
has been changed to:
The problem here is: There is no mismatch, but a pair of empty brackets at an invalid position. Therefore the new error message is misleading, but the previous error message was completely fine. Is it possible to restore the previous message in such cases? |
|
Hi Son, it might be challenging for the JsonPreprocessor to react on this (invalid) code: In the past he did the job very well: This error message has been changed to:
As user I would be lost now. No change to find the position that caused the error. Is it possible to restore the previous error message? |
|
Hi Son, previously:
Now:
In my opinion the first error message is more meaningful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Son,
looks good to me!
Thank you,
Thomas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed wording fine to me now
This pull-request for the Sprint-25.4.1