From eef4d4b8cd86030d4d97fc57c67bbcf69f2cf23c Mon Sep 17 00:00:00 2001 From: Matt Wrock Date: Sat, 21 Mar 2015 16:38:30 -0700 Subject: [PATCH] open zip file in binary mode to avoid injection of carriage returns on windows hosts --- lib/kitchen/transport/winrm/tmp_zip.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/kitchen/transport/winrm/tmp_zip.rb b/lib/kitchen/transport/winrm/tmp_zip.rb index 575c8f689..c7f7be38d 100644 --- a/lib/kitchen/transport/winrm/tmp_zip.rb +++ b/lib/kitchen/transport/winrm/tmp_zip.rb @@ -79,7 +79,7 @@ def initialize(dir, logger = nil) @dir = Pathname.new(dir) @method = ::Zip::Entry::DEFLATED @compression = Zlib::BEST_COMPRESSION - @zip_io = Tempfile.open(["tmpzip-", ".zip"]) + @zip_io = Tempfile.open(["tmpzip-", ".zip"], :binmode => true) write_zip @zip_io.close end