add puppet to the list of ignored names to allow for a per suite puppet ... #447

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@ehaselwanter

...test configuration

otherwise it fails with at the busser install step:

sudo -E ${gem_bindir}/busser setup; sudo -E /tmp/busser/bin/busser plugin install busser-puppet busser-serverspec']

I created a workaround with a fake gem https://rubygems.org/gems/busser-puppet
And I think this should be somehow configurable, but can't think of how ...

lib/kitchen/busser.rb
@@ -189,7 +189,7 @@ def local_suite_files
end
def is_chef_data_dir?(base, file)
- file =~ %r[^#{base}/(data|data_bags|environments|nodes|roles)/]
+ file =~ %r[^#{base}/(data|data_bags|environments|nodes|roles|puppet)/]

This comment has been minimized.

@sethvargo

sethvargo May 27, 2014

Contributor

Does having a puppet folder indicate this is a chef repo? I don't think this change is correct.

@sethvargo

sethvargo May 27, 2014

Contributor

Does having a puppet folder indicate this is a chef repo? I don't think this change is correct.

This comment has been minimized.

@ehaselwanter

ehaselwanter May 27, 2014

you are right. will correct it with another PR. meant to fix non_suite_dirs

@ehaselwanter

ehaselwanter May 27, 2014

you are right. will correct it with another PR. meant to fix non_suite_dirs

@ehaselwanter

This comment has been minimized.

Show comment
Hide comment
@ehaselwanter

ehaselwanter May 27, 2014

much better :-)

much better :-)

@sethvargo

This comment has been minimized.

Show comment
Hide comment
@sethvargo

sethvargo May 27, 2014

Contributor

👍

Contributor

sethvargo commented May 27, 2014

👍

@ehaselwanter

This comment has been minimized.

Show comment
Hide comment
@ehaselwanter

ehaselwanter May 27, 2014

btw. how should we proceed with: https://github.com/neillturner/kitchen-puppet ... there is a pull request (not with the latest version) ... should this go into the main line? or factored out into distinct gems for chef and puppet and ...

btw. how should we proceed with: https://github.com/neillturner/kitchen-puppet ... there is a pull request (not with the latest version) ... should this go into the main line? or factored out into distinct gems for chef and puppet and ...

@neillturner

This comment has been minimized.

Show comment
Hide comment
@neillturner

neillturner Oct 22, 2015

Contributor

i've prefer to remove the old inline kitchen puppet code and stick with the separate gem as it allows faster modification and improvement. I actually think if you pulled out the chef provisioner from the main code it would also allow chef provisioner to be modified an improved faster but that your decision. -)

Contributor

neillturner commented Oct 22, 2015

i've prefer to remove the old inline kitchen puppet code and stick with the separate gem as it allows faster modification and improvement. I actually think if you pulled out the chef provisioner from the main code it would also allow chef provisioner to be modified an improved faster but that your decision. -)

@cheeseplus

This comment has been minimized.

Show comment
Hide comment
@cheeseplus

cheeseplus Jan 15, 2016

Contributor

I am with @neillturner on this one and as such I'm going to close this as we're planning on abstracting out the chef provisioner as suggested.

Contributor

cheeseplus commented Jan 15, 2016

I am with @neillturner on this one and as such I'm going to close this as we're planning on abstracting out the chef provisioner as suggested.

@cheeseplus cheeseplus closed this Jan 15, 2016

@test-kitchen test-kitchen locked and limited conversation to collaborators Nov 16, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.