Fixing bad default setting - if ENV is not set we are accidently setting log_level to nil for whole run #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing log_level to nil for whole run
|
@tyler-ball This fixes the issue for me. It would be nice to add some test coverage to this PR so we ensure the issue doesn't bite us again in the future! |
|
+1 to testing these defaults but yay! Thanks y'all! |
|
Well I am really glad I added coverage - because I found a bug with my original code! I'll merge this if the test looks good to yall |
tyler-ball
force-pushed
the
tball/bad-default
branch
from
7381970
to
3318ef4
Compare
|
@tyler-ball once Travis is happy you should |
tyler-ball
force-pushed
the
tball/bad-default
branch
from
3318ef4
to
8f90990
Compare
|
👍 rock on |
|
Yippie, agreed! |
fnichol
added a commit
that referenced
this pull request
Mar 12, 2015
Fixing bad default setting - if ENV is not set we are accidently setting log_level to nil for whole run
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to https://github.com/test-kitchen/test-kitchen/pull/600/files, which introduced a bug. Not setting ENV[:log_level] causes the converge step to fail because we create the provisioner string
chef-client --log-levelwith no supplied log level.\cc @fnichol @schisamo