Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Dependencies in preparation for next maintenance release #70

Merged
merged 4 commits into from Jul 12, 2019

Conversation

@slu-it
Copy link
Member

commented Jul 12, 2019

This change is Reviewable

@codecov-io

This comment has been minimized.

Copy link

commented Jul 12, 2019

Codecov Report

Merging #70 into master will increase coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #70      +/-   ##
============================================
+ Coverage     90.51%   90.78%   +0.26%     
  Complexity     1565     1565              
============================================
  Files           294      294              
  Lines          3659     3646      -13     
  Branches        130      130              
============================================
- Hits           3312     3310       -2     
+ Misses          274      263      -11     
  Partials         73       73
Impacted Files Coverage Δ Complexity Δ
...r/internal/implementation/PageFragmentFactory.java 57.14% <0%> (-14.29%) 1% <0%> (ø)
...t/webtester/junit/runner/WebTesterJUnitRunner.java 98.13% <0%> (-0.04%) 20% <0%> (ø)
...tit/webtester/browser/factories/RemoteFactory.java 100% <0%> (ø) 8% <0%> (ø) ⬇️
...al/implementation/advices/EventProducerAdvice.java 63.33% <0%> (+1.03%) 1% <0%> (ø) ⬇️
...tion/pagefragments/PageFragmentImplementation.java 71.79% <0%> (+3.5%) 4% <0%> (ø) ⬇️
...ernal/implementation/pages/PageImplementation.java 65.62% <0%> (+3.86%) 4% <0%> (ø) ⬇️
.../webtester/support/hamcrest/WebTesterMatchers.java 100% <0%> (+5.55%) 34% <0%> (ø) ⬇️
...apters/AbstractPropertiesConfigurationAdapter.java 100% <0%> (+14.28%) 3% <0%> (ø) ⬇️
...webtester/support/assertj/WebTesterAssertions.java 100% <0%> (+22.22%) 7% <0%> (ø) ⬇️
...atec/testit/webtester/internal/ClasspathUtils.java 75% <0%> (+25%) 2% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16c24b2...4bc3420. Read the comment docs.

@slu-it slu-it merged commit 992241e into master Jul 12, 2019

9 of 10 checks passed

Better Code Hub Checking the 10 guidelines...
Details
ci/circleci: checkstyle Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: documentation Your tests passed on CircleCI!
Details
ci/circleci: findbugs Your tests passed on CircleCI!
Details
ci/circleci: integration-tests Your tests passed on CircleCI!
Details
ci/circleci: pmd Your tests passed on CircleCI!
Details
ci/circleci: unit-tests Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 16c24b2...4bc3420
Details
codecov/project 90.78% (+0.26%) compared to 16c24b2
Details

@slu-it slu-it deleted the update branch Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.