Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added loading with default configuration for waiting operations #75

Merged
merged 1 commit into from Feb 14, 2020

Conversation

@slu-it
Copy link
Member

slu-it commented Feb 14, 2020

This makes it possible to configure waiting even for non-browser related operations. (e.g. waitUntil { a == true })

@Drakojin does this solve #72 ?


This change is Reviewable

@slu-it slu-it requested a review from Drakojin Feb 14, 2020
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 14, 2020

Codecov Report

Merging #75 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #75      +/-   ##
============================================
+ Coverage     70.98%   71.04%   +0.06%     
  Complexity     1289     1289              
============================================
  Files           292      292              
  Lines          3660     3668       +8     
  Branches        132      132              
============================================
+ Hits           2598     2606       +8     
  Misses          990      990              
  Partials         72       72
Impacted Files Coverage Δ Complexity Δ
...va/info/novatec/testit/webtester/waiting/Wait.java 95.65% <100%> (+2.31%) 10 <7> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28420f3...b29da42. Read the comment docs.

This makes it possible to configure waiting even for non-browser related operations. (e.g. waitUntil { a == true })
@slu-it slu-it force-pushed the waiting_with_defaults_from_config branch from 26605e2 to b29da42 Feb 14, 2020
@slu-it slu-it merged commit 20306a0 into master Feb 14, 2020
10 of 11 checks passed
10 of 11 checks passed
code-review/reviewable 2 files left (Drakojin)
Details
Better Code Hub ✅ Better Code Hub approves this code
Details
ci/circleci: checkstyle Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: documentation Your tests passed on CircleCI!
Details
ci/circleci: findbugs Your tests passed on CircleCI!
Details
ci/circleci: integration-tests Your tests passed on CircleCI!
Details
ci/circleci: pmd Your tests passed on CircleCI!
Details
ci/circleci: unit-tests Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 70.98%)
Details
codecov/project 71.04% (+0.06%) compared to 28420f3
Details
@slu-it slu-it deleted the waiting_with_defaults_from_config branch Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.