Add repeat tag #13
Merged
Add repeat tag #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateusfreira
commented
Aug 20, 2019
mateusfreira
commented
Aug 20, 2019
mateusfreira
commented
Aug 20, 2019
| basicAuth = apiPort.resolveObject(basicAuth) | ||
| delete basicAuth.$file | ||
| } | ||
| requests.forEach((_req) => { |
There was a problem hiding this comment.
because of this new loop, most of the change fro here are indentation only, I would advice to review with Hide whitespace changes enabled. Here is a shortcut to it :) https://github.com/testbetter/openapitest/pull/13/files?w=1
dreich-nucleus
requested changes
Aug 20, 2019
Co-Authored-By: Dave Reich <dreich@nucleushealth.io>
dreich-nucleus
approved these changes
Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention here is to add the capability to repeat a test
Ntimes if the user wants to. For now, we are implementing a straightforward approach.I have added some tests to demo how the feature works for now as well as update the documentation.
Bonus: I added tests to skip and only tags.
Ps: This review will be easier if you do it with
Hide whitespace changesenabled, try it here https://github.com/testbetter/openapitest/pull/13/files?w=1