Skip to content

Conversation

@HofmeisterAn
Copy link
Collaborator

What does this PR do?

This PR extracts ARG statements from the Dockerfile and replaces variables in FROM statements with their values to identify all included base images.

Why is it important?

When Testcontainers for .NET builds an image using ImageFromDockerfileBuilder, it needs to pre-pull the base images referenced in the Dockerfile. Previously, it didn't handle FROM statements with ARG variables, these were skipped. This PR fixes that by resolving ARG statements, using the Dockerfile's default values or any build arguments that override them.

Related issues

@HofmeisterAn HofmeisterAn added the enhancement New feature or request label Sep 21, 2025
@netlify
Copy link

netlify bot commented Sep 21, 2025

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 6a1fad8
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-dotnet/deploys/68d02975be19150008d7021a
😎 Deploy Preview https://deploy-preview-1532--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@HofmeisterAn HofmeisterAn changed the title Feature/resolve args for dockerfile feat: Resolve Dockerfile ARGs pulling base images Sep 21, 2025
@HofmeisterAn HofmeisterAn merged commit b933ae3 into develop Sep 21, 2025
174 of 202 checks passed
@HofmeisterAn HofmeisterAn deleted the feature/resolve-args-for-dockerfile branch September 21, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement]: Resolve variables (ARGs) during Docker image build

2 participants