feat: Resolve Dockerfile ARGs pulling base images #1532
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR extracts
ARGstatements from the Dockerfile and replaces variables inFROMstatements with their values to identify all included base images.Why is it important?
When Testcontainers for .NET builds an image using
ImageFromDockerfileBuilder, it needs to pre-pull the base images referenced in the Dockerfile. Previously, it didn't handleFROMstatements withARGvariables, these were skipped. This PR fixes that by resolvingARGstatements, using the Dockerfile's default values or any build arguments that override them.Related issues
ARGs) during Docker image build #980