From 57505f2a43d2c2439ec4494818ed6e72f006e549 Mon Sep 17 00:00:00 2001 From: rwaweber Date: Fri, 22 Dec 2023 14:39:05 -0500 Subject: [PATCH 1/2] [redpanda] sasl test, wrong mechanism - ensure that when using a different sasl mechanism from the broker, unsupported error is returned --- modules/redpanda/redpanda_test.go | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/modules/redpanda/redpanda_test.go b/modules/redpanda/redpanda_test.go index 7ad424b3bd..b3e70dff5e 100644 --- a/modules/redpanda/redpanda_test.go +++ b/modules/redpanda/redpanda_test.go @@ -15,6 +15,7 @@ import ( "github.com/twmb/franz-go/pkg/kadm" "github.com/twmb/franz-go/pkg/kerr" "github.com/twmb/franz-go/pkg/kgo" + "github.com/twmb/franz-go/pkg/sasl/plain" "github.com/twmb/franz-go/pkg/sasl/scram" ) @@ -158,6 +159,23 @@ func TestRedpandaWithAuthentication(t *testing.T) { assert.ErrorContains(t, err, "SASL_AUTHENTICATION_FAILED") } + // Test wrong mechanism + { + kafkaCl, err := kgo.NewClient( + kgo.SeedBrokers(seedBroker), + kgo.SASL(plain.Auth{ + User: "no-superuser", + Pass: "test", + }.AsMechanism()), + ) + require.NoError(t, err) + + kafkaAdmCl := kadm.NewClient(kafkaCl) + _, err = kafkaAdmCl.Metadata(ctx) + require.Error(t, err) + assert.ErrorContains(t, err, "UNSUPPORTED_SASL_MECHANISM") + } + // Test Schema Registry API httpCl := &http.Client{Timeout: 5 * time.Second} // schemaRegistryAddress { From be93f130f9b347289e25c8b54a9e63cb28183873 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Manuel=20de=20la=20Pe=C3=B1a?= Date: Thu, 1 Feb 2024 11:43:55 +0100 Subject: [PATCH 2/2] chore: use require --- modules/redpanda/redpanda_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/redpanda/redpanda_test.go b/modules/redpanda/redpanda_test.go index 11ecc08944..2a6ed8dde6 100644 --- a/modules/redpanda/redpanda_test.go +++ b/modules/redpanda/redpanda_test.go @@ -177,7 +177,7 @@ func TestRedpandaWithAuthentication(t *testing.T) { kafkaAdmCl := kadm.NewClient(kafkaCl) _, err = kafkaAdmCl.Metadata(ctx) require.Error(t, err) - assert.ErrorContains(t, err, "UNSUPPORTED_SASL_MECHANISM") + require.ErrorContains(t, err, "UNSUPPORTED_SASL_MECHANISM") } // Test Schema Registry API