Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add example of using Pulsar with testcontainers-go #597

Merged
merged 4 commits into from Oct 31, 2022

Conversation

clive-jevons
Copy link
Contributor

@clive-jevons clive-jevons commented Oct 28, 2022

A quick example of how I used Pulsar in a recent test for another project which others might find useful.

It essentially mimics the way the testcontainers-java Pulsar module sets up Pulsar.

@clive-jevons clive-jevons added the documentation Docs, docs, docs. label Oct 28, 2022
@clive-jevons clive-jevons self-assigned this Oct 28, 2022
@clive-jevons clive-jevons requested a review from a team as a code owner October 28, 2022 18:24
@mdelapenya
Copy link
Collaborator

This is super cool!! Thanks for adding the example.

I'd remove the gomega dependency to avoid associating the example with a test framework. I'd use testing library + require or assert. You can check the ones used in the project as a reference.

In any case, this LGTM!!

@mdelapenya
Copy link
Collaborator

I've just realized that the example is not shown in the website because the mkdocs descriptor living in the root for of the project, she's not included the new entry. Could you please add it?

@clive-jevons
Copy link
Contributor Author

This is super cool!! Thanks for adding the example.

I'd remove the gomega dependency to avoid associating the example with a test framework. I'd use testing library + require or assert. You can check the ones used in the project as a reference.

In any case, this LGTM!!

done 👍

... just saw that I had the log-following code still in there ... do you think we should leave that in the example, or should I remove that so it's just showing Pulsar usage?

@clive-jevons
Copy link
Contributor Author

I've just realized that the example is not shown in the website because the mkdocs descriptor living in the root for of the project, she's not included the new entry. Could you please add it?

done 👍

docs/examples/pulsar.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

I've test it locally with success, thanks for this great example on Apache Pulsar usage. Great job

@mdelapenya mdelapenya merged commit 212978a into main Oct 31, 2022
23 checks passed
@mdelapenya mdelapenya deleted the docs/pulsar-example branch October 31, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Docs, docs, docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants