Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use a fixed version of MySQL #617

Merged
merged 1 commit into from Nov 10, 2022

Conversation

mdelapenya
Copy link
Collaborator

@mdelapenya mdelapenya commented Nov 10, 2022

What does this PR do?

It extracts the mysql docker image string to a constant in the tests, using a fixed version (8.0.30) instead of latest.

Why is it important?

Consistency in the code. I'm also seeing certain unstability in the tests consuming the MySQL image when running them in the CI:

goroutine 1743 [sleep]:
time.Sleep(0x5f5e100)
	/opt/hostedtoolcache/go/1.18.7/x64/src/runtime/time.go:194 +0x12e
github.com/testcontainers/testcontainers-go/wait.(*LogStrategy).WaitUntilReady(0xc000846270, {0x2220b20?, 0xc0008be060?}, {0x2223870, 0xc0005f9a40})
	/home/runner/work/testcontainers-go/testcontainers-go/wait/log.go:99 +0x165
github.com/testcontainers/testcontainers-go/wait.(*MultiStrategy).WaitUntilReady(0xc000699520, {0x2220ae8?, 0xc000136000?}, {0x2223870, 0xc0005f9a40})
	/home/runner/work/testcontainers-go/testcontainers-go/wait/all.go:41 +0x12e
github.com/testcontainers/testcontainers-go.(*DockerContainer).Start(0xc0005f9a40, {0x2220ae8, 0xc000136000})
	/home/runner/work/testcontainers-go/testcontainers-go/docker.go:187 +0x248
github.com/testcontainers/testcontainers-go.GenericContainer({_, _}, {{{{0x0, 0x0}, {0x0, 0x0}, {0x0, 0x0}, 0x0, 0x0, ...}, ...}, ...})
	/home/runner/work/testcontainers-go/testcontainers-go/generic.go:75 +0x3d4
github.com/testcontainers/testcontainers-go.TestContainerCreationWaitsForLogAndPortContextTimeout(0xc00077bd40)
	/home/runner/work/testcontainers-go/testcontainers-go/docker_test.go:1318 +0x3af
testing.tRunner(0xc00077bd40, 0x200df68)
	/opt/hostedtoolcache/go/1.18.7/x64/src/testing/testing.go:1439 +0x102
created by testing.(*T).Run
	/opt/hostedtoolcache/go/1.18.7/x64/src/testing/testing.go:1486 +0x35f

Related issues

@mdelapenya mdelapenya marked this pull request as ready for review November 10, 2022 12:06
@mdelapenya mdelapenya requested a review from a team as a code owner November 10, 2022 12:06
@mdelapenya mdelapenya self-assigned this Nov 10, 2022
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Nov 10, 2022
@mdelapenya mdelapenya merged commit 1189044 into testcontainers:main Nov 10, 2022
14 checks passed
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Nov 10, 2022
* main:
  chore: use a fixed version of MySQL (testcontainers#617)
@mdelapenya mdelapenya deleted the use-mysql-fixed branch November 10, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant