Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: retire podman pipeline #625

Merged
merged 1 commit into from Nov 16, 2022

Conversation

mdelapenya
Copy link
Collaborator

@mdelapenya mdelapenya commented Nov 16, 2022

What does this PR do?

It removes the GH workflow for podman, as it started to fail yesterday, pressumably caused by how podamn is installed in the GH runner.

We verified that the last time the podman pipeline passed, it was 4 days ago, using the very same runner than when it started to fail yesterday:

馃煝 last green build: https://github.com/testcontainers/testcontainers-go/actions/runs/3451793607/jobs/5761263469

  • when: 4 days ago
  • OS - Version: ubuntu 22.04.1 - 20221027.1

馃敶 first broken build: https://github.com/testcontainers/testcontainers-go/actions/runs/3469834261/jobs/5797300820

  • when: yesterday
  • OS - Version: ubuntu 22.04.1 - 20221027.1

Why is it important?

The GH check for podman is not required by the branch protection, but it's causing noise in the PRs and merge commits.

Follow-ups

Bring back the pipeline once the installation of podman in the ubuntu runner is fixed, probably at the package manager level.
See #626

@mdelapenya mdelapenya requested a review from a team as a code owner November 16, 2022 11:05
@mdelapenya mdelapenya added dependencies Dependencies or external services podman Issues regarding podman. labels Nov 16, 2022
@mdelapenya mdelapenya self-assigned this Nov 16, 2022
@mdelapenya mdelapenya requested a review from a team November 16, 2022 11:05
kiview
kiview approved these changes Nov 16, 2022
@mdelapenya mdelapenya merged commit 1f88e88 into testcontainers:main Nov 16, 2022
12 checks passed
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Nov 17, 2022
* main:
  docs: update method to `nginxC.Terminate` (testcontainers#627)
  fix: do not prepend garbage in the container.Exec response (testcontainers#624)
  chore: retire podman pipeline (testcontainers#625)
  update gotest.md - fix errors in the example (testcontainers#623)
  chore: sync governance files (testcontainers#622)
@mdelapenya mdelapenya deleted the disable-podman-ci branch November 18, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependencies or external services podman Issues regarding podman.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants