Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

com.google.code.findbugs:jsr305 and the @Nullable annotation #912

Closed
dbyron0 opened this issue Oct 12, 2018 · 2 comments

Comments

@dbyron0
Copy link
Contributor

commented Oct 12, 2018

Apparently since the transition to build with gradle, com.google.code.findbugs:jsr305 has been on the compile classpath for consumers of testcontainers-java.

From what I can tell, we only need it here for the @Nullable annotations in OkHttpInvocationBuilder.java.

My goal is to get jsr305 off the classpath for consumers to reduce the chance for conflicts (with e.g. com.google.code.findbugs:annotations). One way appears to be switching it to a compileOnly dependency (#913). Another way would be to ditch the @Nullable annotations, though if they're adding value, let's keep 'em.

Got some inspiration from google/guava#1018 (comment).

@dbyron0

This comment has been minimized.

Copy link
Contributor Author

commented Oct 15, 2018

There's also this from guava: google/guava#2960 about them ditching jsr305 one day. I can't say I've totally grasped all the issues, nor what the ideal replacement (if any) for testcontainers would be. Here's a PR to remove @Nullable and the dependency on jsr305 though: #920.

@dbyron0

This comment has been minimized.

Copy link
Contributor Author

commented Oct 22, 2018

@kiview kiview closed this in 043e90a Nov 5, 2018

@kiview kiview added this to the next milestone Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.