-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check Docker version according to checksEnabled flag #1231
Check Docker version according to checksEnabled flag #1231
Conversation
Thanks, for the PR. IMO it's enough to move testcontainers-java/core/src/main/java/org/testcontainers/DockerClientFactory.java Line 129 in 8acee4d
to line 132, inside the if body. |
@kiview Thank you for review. I think you are fair enough. But, may be we need some refactoring to move checks in another class. That will really help us if checks start to grow. What do you think about it? If you agree I (or maybe you) can create task to do this refactoring. |
@aivinog1 Having a dedicated environment checking class seems to make sense. I would move all checks there in this case. However, for now this fix is good to go 🙂 |
Merged, thanks a lot for your first contribution! |
#1220