Add MongoDB module

[silaev]

Java8 MongoDbContainer for constructing a single node MongoDB replica set.

[rnorth]

I'm afraid I'm still only about half way through but have run out of time for now - I think there's a few things to discuss. My last comment is possibly the trickiest thing so far.

Thank you for this work so far - hoping we can get this done!

[silaev]

Hi @rnorth,
I resolved all the discussions. Please, review them.

[rnorth]

Sorry, we prefer it if we get the chance to press the resolve button for comments, as it means we can keep track of what we've re-reviewed.

I'm going to unresolve all, but please don't take this as meaning I'm not happy with the change, it's just that I've not re-reviewed yet.

Sorry for the long time between the last review and now.

[silaev]

Sorry, we prefer it if we get the chance to press the resolve button for comments, as it means we can keep track of what we've re-reviewed.

I'm going to unresolve all, but please don't take this as meaning I'm not happy with the change, it's just that I've not re-reviewed yet.

Sorry for the long time between the last review and now.

Hi @rnorth ,

It's fair enough to unresolve all the discussions.
Look forward to getting a feedback from you

[rnorth]

Looking at this again, I'm afraid I feel that we should simplify the testing a lot. There is a lot of code here - which means a lot of code that we have to be willing to maintain.

It seems to me that TransactionITTest is the most important test class, as it (in a black-box manner) actually verifies behaviour of the module rather than arrangement of internals. The behaviour that it verifies ('can we execute a transactional operation using the Mongo drivers') would appear to be key behaviour that matters to users, and thus the one that is most important to test for.

I'd be happy to make these changes myself if you prefer, as I'm keen that we actually get this PR integrated - sorry that it's been so long.

[silaev]

Looking at this again, I'm afraid I feel that we should simplify the testing a lot. There is a lot of code here - which means a lot of code that we have to be willing to maintain.

The testing code here stands for the 90%+ code coverage of MongoDB module, and yet I understand your concern about maintainability.

It seems to me that TransactionITTest is the most important test class, as it (in a black-box manner) actually verifies behaviour of the module rather than arrangement of internals. The behaviour that it verifies ('can we execute a transactional operation using the Mongo drivers') would appear to be key behaviour that matters to users, and thus the one that is most important to test for.

Indeed, TransactionITTest mostly copies the code that MongoDB offical docs set as an example

I'd be happy to make these changes myself if you prefer, as I'm keen that we actually get this PR integrated - sorry that it's been so long.

Ok, please, do it. Also, let me know if you need my help.

[rnorth]

Thanks for being understanding @silaev 🙇‍♂️. I've made tweaks locally; would you mind if I push to your remote? This PR comes from your master branch, so I wanted to check before pushing.

[silaev]

Thanks for being understanding @silaev 🙇‍♂️. I've made tweaks locally; would you mind if I push to your remote? This PR comes from your master branch, so I wanted to check before pushing.

No, I don't mind at all, go ahead, link

[silaev]

@rnorth @bsideup I reduced tests to only one transaction test, also addressed all the discussions above. Could we merge this PR?

[bsideup]

The docs' look weird:
https://deploy-preview-1961--testcontainers.netlify.app/modules/databases/mongodb/

I guess "Java8 MongoDbContainer for constructing a single node MongoDB replica set." is not needed as it is obvious, and the multi-node note should become a note section

Also, I just noticed MongoDb everywhere, while it is MongoDB (upper cased B) - please adjust.

[silaev]

@bsideup I’ve addressed all the discussions, please, check

[rnorth]

Looks Good To Me 😄 🎉

Thank you @silaev for your contribution, epic patience and flexibility as we worked through the reviews. 🙇‍♂️

[silaev]

Looks Good To Me 😄 🎉

Thank you @silaev for your contribution, epic patience and flexibility as we worked through the reviews. 🙇‍♂️

Thank you, my pleasure