Add custom exception message when HealthState not present in docker inspect response
#2206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnorth
reviewed
Dec 27, 2019
core/src/main/java/org/testcontainers/containers/ContainerState.java
Outdated
Show resolved
Hide resolved
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
|
@pivovarit sorry that it got stale! Could you please fix the conflict? Will be happy to merge right after! |
|
@bsideup done! |
bsideup
approved these changes
Mar 26, 2020
|
@pivovarit merged, thanks! 🎉 |
|
This was released in https://github.com/testcontainers/testcontainers-java/releases/tag/1.14.0 🎉 Thanks for the contribution! |
quincy
pushed a commit
to quincy/testcontainers-java
that referenced
this pull request
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2205
I don't think much more can be done without touching the public API. Catching
NullPointerExceptionand returning false instead is likely to introduce confusion. Not sure if defaulting to true is better for the same reason.