Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1167: Consolidate example code snippets #4136

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

aboullaite
Copy link

Move code snippets from docs/examples to examples and update doc links

Signed-off-by: mohammed aboullaite <maboullaite@spotify.com>
Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized, all instances of testImplementation project(":testcontainers") or similar includes in the moved build.gradle files need to be substituted by regular dependency definition, like:

testCompile 'org.testcontainers:testcontainers'

Also, the moved projects need to be added as explicit includes to https://github.com/aboullaite/testcontainers-java/blob/625ddc374cac2447cbbcb59c9d7e07c49ac30e99/examples/settings.gradle#L33, so they get picked up by the build.

Signed-off-by: mohammed aboullaite <maboullaite@spotify.com>
@aboullaite
Copy link
Author

I made some changes! Let me know If I missed something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants