Add SQL Server container #82
Conversation
tests/test_db_containers.py
Outdated
| @@ -100,3 +101,13 @@ def connect(): | |||
| cursor = db.restaurants.find({"borough": "Manhattan"}) | |||
| for document in cursor: | |||
| print(document) | |||
|
|
|||
| @pytest.mark.skip(reason="needs ms sql client libraries unavailable on Travis") | |||
There was a problem hiding this comment.
How we can test it then?
There was a problem hiding this comment.
I'm not sure! I ran it locally and followed the example for Oracle here... I thought it wouldn't work in Travis because of discussions like this one, but it might just work using sqlalchemy.
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
==========================================
- Coverage 84.94% 82.01% -2.94%
==========================================
Files 19 20 +1
Lines 392 417 +25
Branches 25 28 +3
==========================================
+ Hits 333 342 +9
- Misses 43 59 +16
Partials 16 16
Continue to review full report at Codecov.
|
|
Hi @annabaas, thank you for the PR. Could you run |
|
@tillahoffmann thank you! that should fix the tests (I hope). The script failed for 3.8 ("ModuleNotFoundError: No module named 'Cython'"), I added the req manually for that one as I don't think the issue is related to my PR. |
|
It definitely is related. Sorry :( |
|
It looks like |
|
It seems to be nontrivial to get pymssql to work with 3.8, and pymssql support is being withdrawn :( I'll close this PR and open a new one if we get it to work with ODBC or one of the alternatives. |
|
Sounds like a plan. 🙂 Feel free to keep pushing changes here to see whether everything builds/tests as expected, and we can squash merge afterwards. |
|
Thank you! |
Please let me know if it requires anything else!