Implement MUnit integration#119
Conversation
| startedContainers.foreach(_.stop()) | ||
| } | ||
| finally { | ||
| startedContainers = None |
There was a problem hiding this comment.
Correct me if im wrong, but it looks like you have a potential race condition here. If you add a new container between line 103 and line 106 are executed (and those lines are not atomic), you wont stop the new container. From my understanding all operations on containers should be synchronized
There was a problem hiding this comment.
Actually I'm not sure it's worth to change state of startedContainers here at all. Probably at this point, it doesn't change anything.
LMnet
left a comment
LMnet
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
Besides integration implementation is would be nice to have documentation about munit module. Could you please add it? Few examples with main concepts would be enough.
Also, it looks like munit integration doesn't support all scalatest integration features. These limitations should be highlighted in the documentation too.
| .dependsOn( | ||
| core, | ||
| scalatest, | ||
| munit, |
There was a problem hiding this comment.
allOld module is only for backward compatibility. You don't need to add new modules (like munit) to this module.
|
@psisoyev thank you for your contribution! I'll take a closer look and merge over the weekend |
|
I realized that I didn't put MUnit related classes to munit package. I guess that should be done as well. What do you think? |
Yes, unit stuff should be in the separate package. |
4 participants
I have implemented MUnit integration.
There is a known issue, though: currently, in MUnit it is not possible to retrieve test status in afterAll/afterEach block so I always pass no error to
afterTestmethod