"ci mode app runs them tests on node, nodetap, and browser" test failing #377

Closed
duncan-bayne opened this Issue Jun 20, 2014 · 0 comments

1 participant

@duncan-bayne

I've cloned the repo, installed the dependencies, and run the tests with npm test. There is one failing test:

 162 passing (1s)
  1 failing

  1) ci mode app runs them tests on node, nodetap, and browser:
     Uncaught AssertionError: expected [ Array(6) ] to include 'PhantomJS 1.9'
      at Function.assert.include (/home/duncan/testem/node_modules/chai/lib/chai/interface/assert.js:659:45)
      at EventEmitter.<anonymous> (/home/duncan/testem/tests/ci/ci_tests.js:59:16)
      at Function.spy.notify (/home/duncan/testem/node_modules/ispy/index.js:59:10)
      at EventEmitter.spy [as cleanExit] (/home/duncan/testem/node_modules/ispy/index.js:7:9)
      at EventEmitter.App.exit (/home/duncan/testem/lib/ci/index.js:166:10)
      at Server.g (events.js:180:16)
      at Server.emit (events.js:117:20)
      at net.js:1276:10
      at process._tickCallback (node.js:419:13)
@airportyh airportyh pushed a commit that closed this issue Oct 1, 2014
@duncan-bayne duncan-bayne Passes spec if any version of PhantomJS is found in the launchers. (f…
…ixes #377)

This spec was failing on my development machine because the version of
PhantomJS installed (1.6.0) didn't match the version hard-coded in the
assertion (1.9.0).

The fix was to make the test assert that any version of PhantomJS is
included, by matching the regex /^PhantomJS \d/.
4f40a37
@airportyh airportyh closed this in 4f40a37 Oct 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment