Wait for on_exit to finish on failure #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The on_exit hook was being called on failure, but the lifecycle system wasn't waiting for the hook to finish (i.e., call the callback passed to it) before exiting. This led to unwanted side effects, so this commit fixes this issue.
|
This should fully fix #1125. |
|
Thanks 🙏 |
|
👍 could you release a new version for this? |
|
Yes, I was waiting for a last PR to land. Released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The on_exit hook was being called on failure as part of #1157 ,
but the lifecycle system wasn't waiting for the hook to finish (i.e.,
call the callback passed to it) before exiting. This led to unwanted
side effects, so this commit fixes this issue.