Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap Google Chrome with dbus-launch #778

Closed
wants to merge 0 commits into from

Conversation

davidhao3300
Copy link
Contributor

As discussed here: #772
I'm not sure how to test for any regressions given that tests appear to be run through mocha and not through any browsers.

@johanneswuerbach
Copy link
Member

I still don't think this should be part of testem and instead dbus-launch --exit-with-session testem should be used. Wouldn't this work?

The reason I tend more to 👎 is that can I'm not sure that every Linux having dbus-launch can wrap chrome like this? What if people using testem in a existing GUI session?

@davidhao3300
Copy link
Contributor Author

Yeah, I'm hoping someone with a Linux browser/anyone who's had problems could speak up.

@davidhao3300
Copy link
Contributor Author

The solution you suggested should work for us, so this PR isn't really critical

@davidhao3300
Copy link
Contributor Author

Maybe better would be to just add something to the docs regarding this issue?

@johanneswuerbach
Copy link
Member

Yep, I would prefer this. For the current change I just am not able to predict whether this might break anybody or not 😢 .

@johanneswuerbach
Copy link
Member

Any update on this?

@davidhao3300
Copy link
Contributor Author

I'll add the docs some time next week, have final exams lol

@johanneswuerbach
Copy link
Member

No worries and good luck with your finals! :-)

@manish-northout
Copy link

still chromium and chrome are not working through.could you please have a look guys.because locally when i run the test-case its working in Ubuntu 16.04.

@johanneswuerbach
Copy link
Member

Could you create a new issue with also including additional details about your config and environment? Without this, this is hardly actionable and likely forgotten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants