Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented attachFile() #37

Merged
merged 3 commits into from Apr 8, 2021
Merged

Implemented attachFile() #37

merged 3 commits into from Apr 8, 2021

Conversation

diegoperini
Copy link
Member

No description provided.

gmegidish
gmegidish reviewed Apr 8, 2021
View reviewed changes
index.js Outdated Show resolved Hide resolved
gmegidish
gmegidish requested changes Apr 8, 2021
View reviewed changes
Copy link
Member

@gmegidish gmegidish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove creations of directories
Added mime type (which is ignored atm until we add it to the iOS and Android SDK)
When done, go ahead and merge

vijaysharm
vijaysharm approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@vijaysharm vijaysharm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@diegoperini diegoperini merged commit 6a3dc59 into master Apr 8, 2021
@vijaysharm vijaysharm deleted the feat-attach-file branch April 12, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmegidish gmegidish gmegidish requested changes

@vijaysharm vijaysharm vijaysharm approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diegoperini @vijaysharm @gmegidish