Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included a feature for witness to be downloaded #6

Conversation

naveensrinivasan
Copy link

Witness Downloaded from Witness Repository

  • The witness binary could become stale if it is in the repository.
  • It is not recommended to have binary in the repository
  • I don't know if the goal is not to download the binary

Changes in this PR

- The witness binary would be downloaded from the witness repo and validated
  for the checksum
- Included tests `__tests__/index.test.js`
- Removed node_modules dir
- Included `npm ci  run` have npm to be installed during runtime
- Fixed a few npm audit fixes.

- The witness binary would be downloaded from witness repo and validated
  for the checksum
- Included tests
- Removed node_modules dir
- Included npm_ci to run have npm to be installed during runtime
- Fixed few npm audit fixes.

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
@colek42
Copy link
Member

colek42 commented Oct 29, 2023

We included the UPX packed binary in the repo to help the with performance. I wonder if there is a way we could use GitHub's cache to get the best of both worlds. I would certainly like to keep the binary out of this repo, it would make things much cleaner.

@naveensrinivasan
Copy link
Author

UPX packed binary

What is the advantage of the UPX-packed binary? My ignorance.

How can the end-user trust the GH action with the binary without any provenance or verifiability? Probably, if the repo provides an answer for that, it would make it easier.

@jkjell jkjell closed this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants