New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added verbose error information #77

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@Alexei-Kornienko

Added verbose error message about why test cannot be loaded.

Partial-Fix for https://bugs.launchpad.net/testrepository/+bug/1271133

To fix this bug we need to add changes to 3 projects:
testrepository - https://code.launchpad.net/~alexei-kornienko/testrepository/bug-1271133
testtools - #77
subunit - https://code.launchpad.net/~alexei-kornienko/subunit/bug-1271133

Added verbose error information
Added verbose error message about why test cannot be loaded.

Partial-Fix for https://bugs.launchpad.net/testrepository/+bug/1271133
@@ -54,7 +54,15 @@ def list_test(test):
for test in iterate_tests(test):
# to this ugly.
if test.id().startswith(unittest_import_str):
errors.append(test.id()[len(unittest_import_str):])
failure = getattr(test, test._testMethodName)

This comment has been minimized.

@rbtcollins

rbtcollins Feb 10, 2014

Member

Wow, this is ugly :)

So - I believe this should be properly fixed up stream - http://bugs.python.org/issue19746 as referenced in the docstring here.

Doing this poking under the hood is fragile - I suspect we'll need a bunch of careful logic to work with different releases of Python.

We definitely need some prose here explaining whats going on.

@rbtcollins

rbtcollins Feb 10, 2014

Member

Wow, this is ugly :)

So - I believe this should be properly fixed up stream - http://bugs.python.org/issue19746 as referenced in the docstring here.

Doing this poking under the hood is fragile - I suspect we'll need a bunch of careful logic to work with different releases of Python.

We definitely need some prose here explaining whats going on.

@rbtcollins

This comment has been minimized.

Show comment
Hide comment
@rbtcollins

rbtcollins Mar 6, 2015

Member

I believe we've fully fixed this with the upstream improvements. Please reopen and update if I'm wrong.

Member

rbtcollins commented Mar 6, 2015

I believe we've fully fixed this with the upstream improvements. Please reopen and update if I'm wrong.

@rbtcollins rbtcollins closed this Mar 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment