From a361d1b78bd8c0bdcd2d33697f85e1a5118f5b06 Mon Sep 17 00:00:00 2001 From: Kai Hao Date: Sat, 23 Oct 2021 21:00:53 +0800 Subject: [PATCH] Prioritize aria names over hidden in byRole queries --- src/queries/role.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/queries/role.js b/src/queries/role.js index 826edd43..339647a6 100644 --- a/src/queries/role.js +++ b/src/queries/role.js @@ -153,13 +153,6 @@ function queryAllByRole( // don't care if aria attributes are unspecified return true }) - .filter(element => { - return hidden === false - ? isInaccessible(element, { - isSubtreeInaccessible: cachedIsSubtreeInaccessible, - }) === false - : true - }) .filter(element => { if (name === undefined) { // Don't care @@ -176,6 +169,13 @@ function queryAllByRole( text => text, ) }) + .filter(element => { + return hidden === false + ? isInaccessible(element, { + isSubtreeInaccessible: cachedIsSubtreeInaccessible, + }) === false + : true + }) } function makeRoleSelector(role, exact, customNormalizer) {