From 4c0476ada05a7d2ba06d0335e5a4e753d30b0835 Mon Sep 17 00:00:00 2001 From: Olzhas Askar Date: Sun, 13 Oct 2019 00:13:30 +0200 Subject: [PATCH 1/6] chore(templates): replace to newer repo links --- .github/ISSUE_TEMPLATE.md | 4 ++-- .github/ISSUE_TEMPLATE/Feature_Request.md | 2 +- .github/PULL_REQUEST_TEMPLATE.md | 12 ++++++++---- 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index b7ac4df3..5f8e059a 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -12,7 +12,7 @@ learn how: http://kcd.im/pull-request If this is an issue with the documentation, please file an issue in the docs repo: -https://github.com/alexkrolick/testing-library-docs +https://github.com/testing-library/testing-library-docs --> @@ -32,7 +32,7 @@ What happened: Reproduction repository: -https://github.com/alexkrolick/dom-testing-library-template +https://github.com/testing-library/dom-testing-library-template ### Describe the feature you'd like: diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index c08fe410..e25ab7bd 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -34,11 +34,15 @@ merge of your pull request! -- [ ] Documentation added to the - [docs site](https://github.com/alexkrolick/testing-library-docs) -- [ ] I've prepared a PR for types targetting https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/testing-library__dom +- [ ] Documentation added to the [docs site][docs] +- [ ] I've prepared a PR for types targeting [DefinitelyTyped][types] - [ ] Tests - [ ] Ready to be merged - + + + +[docs]: https://github.com/testing-library/testing-library-docs +[types]: + https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/testing-library__dom From 6c68baba368e77d44ae9e6d4d4aae11e98736f9a Mon Sep 17 00:00:00 2001 From: Olzhas Askar Date: Sun, 13 Oct 2019 00:14:04 +0200 Subject: [PATCH 2/6] chore: align with issue template --- .github/ISSUE_TEMPLATE/Bug_Report.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/Bug_Report.md b/.github/ISSUE_TEMPLATE/Bug_Report.md index 0b4ad775..fe35f318 100644 --- a/.github/ISSUE_TEMPLATE/Bug_Report.md +++ b/.github/ISSUE_TEMPLATE/Bug_Report.md @@ -26,7 +26,7 @@ https://github.com/testing-library/testing-library-docs ### Relevant code or config: -```js +```javascript var your => (code) => here; ``` From a9927d81e0be196396d7e9e0ea53e0394b814a20 Mon Sep 17 00:00:00 2001 From: Olzhas Askar Date: Sun, 13 Oct 2019 00:16:32 +0200 Subject: [PATCH 3/6] chore: replace http with https --- .github/ISSUE_TEMPLATE.md | 2 +- .github/ISSUE_TEMPLATE/Bug_Report.md | 2 +- .github/ISSUE_TEMPLATE/Feature_Request.md | 2 +- .github/PULL_REQUEST_TEMPLATE.md | 2 +- CODE_OF_CONDUCT.md | 7 ++++--- package.json | 2 +- 6 files changed, 9 insertions(+), 8 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 5f8e059a..b74b9082 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -8,7 +8,7 @@ understand what's going on and fix the issue. I'll probably ask you to submit the fix (after giving some direction). If you've never done that before, that's great! Check this free short video tutorial to -learn how: http://kcd.im/pull-request +learn how: https://kcd.im/pull-request If this is an issue with the documentation, please file an issue in the docs repo: diff --git a/.github/ISSUE_TEMPLATE/Bug_Report.md b/.github/ISSUE_TEMPLATE/Bug_Report.md index fe35f318..c5415801 100644 --- a/.github/ISSUE_TEMPLATE/Bug_Report.md +++ b/.github/ISSUE_TEMPLATE/Bug_Report.md @@ -14,7 +14,7 @@ about: Bugs, missing documentation, or unexpected behavior 🤔. We'll probably ask you to submit the fix (after giving some direction). If you've never done that before, that's great! Check this free short video -tutorial to learn how: http://kcd.im/pull-request +tutorial to learn how: https://kcd.im/pull-request If this is an issue with the documentation, please file an issue in the docs repo: https://github.com/testing-library/testing-library-docs diff --git a/.github/ISSUE_TEMPLATE/Feature_Request.md b/.github/ISSUE_TEMPLATE/Feature_Request.md index 1bdbe86e..7af3d507 100644 --- a/.github/ISSUE_TEMPLATE/Feature_Request.md +++ b/.github/ISSUE_TEMPLATE/Feature_Request.md @@ -17,7 +17,7 @@ to work on. It'd be great if after the discussion you're the one who submits the PR that implements this feature. If you've never done that before, that's great! Check -this free short video tutorial to learn how: http://kcd.im/pull-request +this free short video tutorial to learn how: https://kcd.im/pull-request If this is an issue with the documentation, please file an issue in the docs repo: diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index e25ab7bd..c6767f07 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -8,7 +8,7 @@ Also, please make sure you're familiar with and follow the instructions in the contributing guidelines (found in the CONTRIBUTING.md file). If you're new to contributing to open source projects, you might find this free -video course helpful: http://kcd.im/pull-request +video course helpful: https://kcd.im/pull-request Please fill out the information below to expedite the review and (hopefully) merge of your pull request! diff --git a/CODE_OF_CONDUCT.md b/CODE_OF_CONDUCT.md index 070cb5f6..30076968 100644 --- a/CODE_OF_CONDUCT.md +++ b/CODE_OF_CONDUCT.md @@ -69,7 +69,8 @@ members of the project's leadership. ## Attribution This Code of Conduct is adapted from the [Contributor Covenant][homepage], -version 1.4, available at [http://contributor-covenant.org/version/1/4][version] +version 1.4, available at +[https://contributor-covenant.org/version/1/4][version] -[homepage]: http://contributor-covenant.org -[version]: http://contributor-covenant.org/version/1/4/ +[homepage]: https://contributor-covenant.org +[version]: https://contributor-covenant.org/version/1/4/ diff --git a/package.json b/package.json index 115e96de..87f2a314 100644 --- a/package.json +++ b/package.json @@ -17,7 +17,7 @@ "end-to-end", "e2e" ], - "author": "Kent C. Dodds (http://kentcdodds.com/)", + "author": "Kent C. Dodds (https://kentcdodds.com/)", "license": "MIT", "engines": { "node": ">=8" From 278fd73571edd23644879b56064e9cca593f6ba3 Mon Sep 17 00:00:00 2001 From: Olzhas Askar Date: Wed, 16 Oct 2019 09:58:12 +0200 Subject: [PATCH 4/6] chore: prefer js instead of javascript --- .github/ISSUE_TEMPLATE.md | 2 +- .github/ISSUE_TEMPLATE/Bug_Report.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index b74b9082..e35a0c35 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -22,7 +22,7 @@ https://github.com/testing-library/testing-library-docs Relevant code or config -```javascript +```js ``` What you did: diff --git a/.github/ISSUE_TEMPLATE/Bug_Report.md b/.github/ISSUE_TEMPLATE/Bug_Report.md index c5415801..b08c624d 100644 --- a/.github/ISSUE_TEMPLATE/Bug_Report.md +++ b/.github/ISSUE_TEMPLATE/Bug_Report.md @@ -26,7 +26,7 @@ https://github.com/testing-library/testing-library-docs ### Relevant code or config: -```javascript +```js var your => (code) => here; ``` From 8ee17da1e4ba2bc6f721484bbfdeee1208ae68c3 Mon Sep 17 00:00:00 2001 From: Olzhas Askar Date: Wed, 16 Oct 2019 10:00:12 +0200 Subject: [PATCH 5/6] chore: return a comment to its previous place --- .github/PULL_REQUEST_TEMPLATE.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index c6767f07..df1f5cc4 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -38,8 +38,7 @@ merge of your pull request! - [ ] I've prepared a PR for types targeting [DefinitelyTyped][types] - [ ] Tests - [ ] Ready to be merged - - + From f852c1806372bac5edbe1416c9d1ce0e87d1a72e Mon Sep 17 00:00:00 2001 From: Olzhas Askar Date: Thu, 17 Oct 2019 00:02:14 +0200 Subject: [PATCH 6/6] chore: inline links --- .github/PULL_REQUEST_TEMPLATE.md | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index df1f5cc4..e0e348bf 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -34,14 +34,12 @@ merge of your pull request! -- [ ] Documentation added to the [docs site][docs] -- [ ] I've prepared a PR for types targeting [DefinitelyTyped][types] +- [ ] Documentation added to the + [docs site](https://github.com/testing-library/testing-library-docs) +- [ ] I've prepared a PR for types targeting + [DefinitelyTyped](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/testing-library__dom) - [ ] Tests - [ ] Ready to be merged - -[docs]: https://github.com/testing-library/testing-library-docs -[types]: - https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/testing-library__dom