From e3923883edb08a8076b4a2cfdb2ddb917a9ae0ee Mon Sep 17 00:00:00 2001 From: Sebastian Silbermann Date: Sun, 13 Oct 2019 18:20:51 +0200 Subject: [PATCH] chore: Improve byRole performance --- src/queries/role.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/queries/role.js b/src/queries/role.js index 4713cfe5..be031475 100644 --- a/src/queries/role.js +++ b/src/queries/role.js @@ -14,9 +14,6 @@ function queryAllByRole( const matchNormalizer = makeNormalizer({collapseWhitespace, trim, normalizer}) return Array.from(container.querySelectorAll('*')) - .filter(element => { - return hidden === false ? isInaccessible(element) === false : true - }) .filter(node => { const isRoleSpecifiedExplicitly = node.hasAttribute('role') @@ -30,6 +27,9 @@ function queryAllByRole( matcher(implicitRole, node, role, matchNormalizer), ) }) + .filter(element => { + return hidden === false ? isInaccessible(element) === false : true + }) } const getMultipleError = (c, role) =>