From 6433c39d831cb0105ddcd6cfcdd4ed720a608df0 Mon Sep 17 00:00:00 2001 From: Deniz Susman Date: Sun, 19 Jul 2020 15:10:50 +0300 Subject: [PATCH 1/2] Typo fix --- src/role-helpers.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/role-helpers.js b/src/role-helpers.js index ca964136..1d110b6d 100644 --- a/src/role-helpers.js +++ b/src/role-helpers.js @@ -154,7 +154,7 @@ function getRoles(container, {hidden = false} = {}) { function prettyRoles(dom, {hidden}) { const roles = getRoles(dom, {hidden}) - //We prefer to skip generic role, we don't reccomand it + //We prefer to skip generic role, we don't recommend it return Object.entries(roles) .filter(([role]) => role !== 'generic') .map(([role, elements]) => { From 9e3bb8c1e209e0b00807ced2976bb5f56072763c Mon Sep 17 00:00:00 2001 From: "Kent C. Dodds" Date: Sun, 19 Jul 2020 07:58:28 -0600 Subject: [PATCH 2/2] Apply suggestions from code review --- src/role-helpers.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/role-helpers.js b/src/role-helpers.js index 1d110b6d..10112b0e 100644 --- a/src/role-helpers.js +++ b/src/role-helpers.js @@ -154,7 +154,7 @@ function getRoles(container, {hidden = false} = {}) { function prettyRoles(dom, {hidden}) { const roles = getRoles(dom, {hidden}) - //We prefer to skip generic role, we don't recommend it + // We prefer to skip generic role, we don't recommend it return Object.entries(roles) .filter(([role]) => role !== 'generic') .map(([role, elements]) => {