Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reference Node and MutationObserver off of the window object #77

Merged
merged 1 commit into from Jul 19, 2018

Conversation

Projects
None yet
2 participants
@dadamssg
Copy link
Contributor

commented Jul 19, 2018

fix: Reference Node and MutationObserver off of the window object rather than globally

You have to handle shims yourself if not using jest without this

What:
Changes references to Node and MutationObserver to use window rather than globally.

Why:
The polyfills/shims do not work in a non-jest environment

How:
Node -> window.Node
MutationObserver -> window.MutationObserver

Checklist:

  • Documentation N/A
  • Tests N/A
  • Ready to be merged
  • Added myself to contributors table
fix: Reference Node and MutationObserver off of the window object rat…
…her than globally

You have to handle shims yourself if not using jest without this
@kentcdodds
Copy link
Member

left a comment

Thanks!

@kentcdodds kentcdodds merged commit 7730d25 into testing-library:master Jul 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kentcdodds

This comment has been minimized.

Copy link
Member

commented Jul 19, 2018

Would you like to add yourself to the contributors table?

@kentcdodds

This comment has been minimized.

Copy link
Member

commented Jul 19, 2018

🎉 This PR is included in version 3.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dadamssg

This comment has been minimized.

Copy link
Contributor Author

commented Jul 19, 2018

Sure! I felt awkward doing that with such a small change. Should I make another commit on this branch? or create a new one?

@kentcdodds

This comment has been minimized.

Copy link
Member

commented Jul 19, 2018

I recommend creating a new branch for every PR.

You may also appreciate this: http://makeapullrequest.com/ :)

@dadamssg

This comment has been minimized.

Copy link
Contributor Author

commented Jul 19, 2018

I definitely appreciate that :)

@dadamssg dadamssg referenced this pull request Jul 19, 2018

Merged

added dadamssg as contributor #78

1 of 4 tasks complete

alexkrolick added a commit to alexkrolick/dom-testing-library that referenced this pull request Sep 13, 2018

fix(TS): examples + types (testing-library#77)
* Update README with new match examples

* Update types

(probably invalid typescript syntax)

* Remove example that messes up TOC

* Fix union type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.