From 4bb2466eaaae9458e6f2e7d53db4d58bd9fdd68d Mon Sep 17 00:00:00 2001 From: YardenShoham Date: Thu, 19 Sep 2019 13:32:58 +0300 Subject: [PATCH 1/3] add yardenshoham to contributors --- .all-contributorsrc | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.all-contributorsrc b/.all-contributorsrc index 81138191..efafee6c 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -277,6 +277,15 @@ "code", "test" ] + }, + { + "login": "yardenshoham", + "name": "Yarden Shoham", + "avatar_url": "https://avatars1.githubusercontent.com/u/20454870?s=460&v=4", + "profile": "https://github.com/YardenShoham", + "contributions": [ + "doc" + ] } ] } From f1aed92e4fede5bc7c8e93b1cfe92d4c878eacbd Mon Sep 17 00:00:00 2001 From: YardenShoham Date: Thu, 19 Sep 2019 14:22:45 +0300 Subject: [PATCH 2/3] chore: add yardenshoham to README.md --- .all-contributorsrc | 4 ++-- README.md | 10 +++++++--- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/.all-contributorsrc b/.all-contributorsrc index efafee6c..61a45cd7 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -279,9 +279,9 @@ ] }, { - "login": "yardenshoham", + "login": "YardenShoham", "name": "Yarden Shoham", - "avatar_url": "https://avatars1.githubusercontent.com/u/20454870?s=460&v=4", + "avatar_url": "https://avatars3.githubusercontent.com/u/20454870?v=4", "profile": "https://github.com/YardenShoham", "contributions": [ "doc" diff --git a/README.md b/README.md index d913b8ae..bd7428c9 100644 --- a/README.md +++ b/README.md @@ -21,7 +21,7 @@ [![version][version-badge]][package] [![downloads][downloads-badge]][npmtrends] [![MIT License][license-badge]][license] -[![All Contributors](https://img.shields.io/badge/all_contributors-27-orange.svg?style=flat-square)](#contributors-) +[![All Contributors](https://img.shields.io/badge/all_contributors-28-orange.svg?style=flat-square)](#contributors-) [![PRs Welcome][prs-badge]][prs] [![Code of Conduct][coc-badge]][coc] [![Watch on GitHub][github-watch-badge]][github-watch] @@ -97,7 +97,8 @@ Import `@testing-library/jest-dom/extend-expect` once (for instance in your import '@testing-library/jest-dom/extend-expect' ``` -> Note: If you're using TypeScript, make sure your setup file is a `.ts` and not a `.js` to include the necessary types. +> Note: If you're using TypeScript, make sure your setup file is a `.ts` and not +> a `.js` to include the necessary types. Alternatively, you can selectively import only the matchers you intend to use, and extend jest's `expect` yourself: @@ -108,7 +109,9 @@ import {toBeInTheDocument, toHaveClass} from '@testing-library/jest-dom' expect.extend({toBeInTheDocument, toHaveClass}) ``` -> Note: when using TypeScript, this way of importing matchers won't provide the necessary type definitions. More on this [here](https://github.com/testing-library/jest-dom/pull/11#issuecomment-387817459). +> Note: when using TypeScript, this way of importing matchers won't provide the +> necessary type definitions. More on this +> [here](https://github.com/testing-library/jest-dom/pull/11#issuecomment-387817459). ## Custom matchers @@ -1072,6 +1075,7 @@ Thanks goes to these people ([emoji key][emojis]): hiwelo.
hiwelo.

💻 🤔 ⚠️ Łukasz Fiszer
Łukasz Fiszer

💻 Jean Chung
Jean Chung

💻 ⚠️ + Yarden Shoham
Yarden Shoham

📖 From 254cab2050715cd64a53a8c01ed46a633673f8cc Mon Sep 17 00:00:00 2001 From: YardenShoham Date: Thu, 19 Sep 2019 14:23:11 +0300 Subject: [PATCH 3/3] chore: add "Added to contributors" to template --- .github/PULL_REQUEST_TEMPLATE.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index cdbf0fbb..8219f6c2 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -39,5 +39,6 @@ merge of your pull request! - [ ] Updated Type Definitions - [ ] Ready to be merged +- [ ] Added myself to the contributors list