From a19180b1e7a991e671c502c19aa24f5dc92b92ca Mon Sep 17 00:00:00 2001 From: Brian Lu Date: Mon, 11 Nov 2024 14:56:32 -0500 Subject: [PATCH 1/2] fix(a11y): underline links surrounded by text --- src/css/custom.css | 14 +++++++++----- src/pages/help.js | 6 ++++-- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/src/css/custom.css b/src/css/custom.css index 10e003c1f..0fc18632b 100644 --- a/src/css/custom.css +++ b/src/css/custom.css @@ -3,15 +3,15 @@ } [data-theme='dark']:root { - --ifm-color-primary: #7FA8F1; - --ifm-link-color: #7FA8F1; + --ifm-color-primary: #7fa8f1; + --ifm-link-color: #7fa8f1; --docsearch-muted-color: white; } [data-theme='light']:root { - --ifm-color-primary: #1554B7; - --ifm-link-color: #1554B7; - --docsearch-muted-color: #494B5F; + --ifm-color-primary: #1554b7; + --ifm-link-color: #1554b7; + --docsearch-muted-color: #494b5f; } .wrapper { @@ -483,6 +483,10 @@ details.alert div { padding-top: 0; } +.linkInTextBlock a { + text-decoration: underline; +} + @media only screen and (min-width: 1024px) { .projectTitle { margin-top: 80px; diff --git a/src/pages/help.js b/src/pages/help.js index a5e318d1e..ea5e5db02 100755 --- a/src/pages/help.js +++ b/src/pages/help.js @@ -64,18 +64,20 @@ export default function Help(props) {

Need help?

Buy a course

-

+

Learn how to test JavaScript with{' '} Kent C. Dodds @@ -105,7 +107,7 @@ export default function Help(props) { community successful and improve tests for everyone in the long run.

-

+

Please consider helping us answer community questions and update documentation content via the help links above. You can also help support{' '} From 2637f22532cc9df06bdf095be0d9332e2a9dbab1 Mon Sep 17 00:00:00 2001 From: Brian Lu Date: Mon, 11 Nov 2024 16:14:46 -0500 Subject: [PATCH 2/2] chore(name): updating class name to be clearer --- src/css/custom.css | 2 +- src/pages/help.js | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/css/custom.css b/src/css/custom.css index 0fc18632b..d53c680a6 100644 --- a/src/css/custom.css +++ b/src/css/custom.css @@ -483,7 +483,7 @@ details.alert div { padding-top: 0; } -.linkInTextBlock a { +.textBlockWithLinks a { text-decoration: underline; } diff --git a/src/pages/help.js b/src/pages/help.js index ea5e5db02..2cbdb30fe 100755 --- a/src/pages/help.js +++ b/src/pages/help.js @@ -64,20 +64,20 @@ export default function Help(props) {

Need help?

Buy a course

-

+

Learn how to test JavaScript with{' '} Kent C. Dodds @@ -107,7 +107,7 @@ export default function Help(props) { community successful and improve tests for everyone in the long run.

-

+

Please consider helping us answer community questions and update documentation content via the help links above. You can also help support{' '}