Sync docs with latest dom-testing-library #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afontcu
reviewed
Apr 1, 2020
Comment on lines
19
to
20
| // adds special assertions like toHaveTextContent | ||
| import '@testing-library/jest-dom/extend-expect' |
Member
There was a problem hiding this comment.
If we remove jest-dom then we can't use toHaveTextContent on line 64 😇
Same thing with other import removals
pustovalov
force-pushed
the
dom-testing-library
branch
from
ec21f37 to
1a5ba09
Compare
pustovalov
force-pushed
the
dom-testing-library
branch
from
1a5ba09 to
80bc99e
Compare
Member
|
@all-contributors please add @pustovalov for docs |
Contributor
|
I've put up a pull request to add @pustovalov! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/testing-library/dom-testing-library/releases