Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upload): be robust against missing FileList implementation #1007

merged 2 commits into from
Aug 2, 2022


Copy link


Guard against missing window.FileList and invalid HTMLInputElement.files.


Closes #940


  • Tests
  • Ready to be merged

Copy link

codesandbox-ci bot commented Aug 1, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7af8920:

Sandbox Source
userEvent-dom Configuration
userEvent-react Configuration
relaxed-meitner-fxe397 Issue #940
hungry-minsky-vk6v1v Issue #940

Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #1007 (7af8920) into main (1c156c2) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #1007   +/-   ##
  Coverage   100.00%   100.00%           
  Files           87        87           
  Lines         1876      1886   +10     
  Branches       679       682    +3     
+ Hits          1876      1886   +10     
Impacted Files Coverage Δ
src/utils/dataTransfer/FileList.ts 100.00% <100.00%> (ø)
src/utils/edit/setFiles.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@ph-fritsche ph-fritsche merged commit a46b4d7 into main Aug 2, 2022
@ph-fritsche ph-fritsche deleted the fix-filelist branch August 2, 2022 12:32
Copy link

github-actions bot commented Aug 2, 2022

🎉 This PR is included in version 14.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

File upload fails in happy-dom
1 participant