Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose report path through maven plugin #459

Closed
MykolaGolubyev opened this issue Nov 25, 2019 · 5 comments · Fixed by #1168
Closed

expose report path through maven plugin #459

MykolaGolubyev opened this issue Nov 25, 2019 · 5 comments · Fixed by #1168
Labels
good first issue Good for newcomers

Comments

@MykolaGolubyev
Copy link
Member

Config values are defined in: com.twosigma.webtau.cfg.WebTauConfig
Maven plugin entry point: com.twosigma.webtau.maven.WebTauMavenRun
Config key to expose: reportPath

@MykolaGolubyev MykolaGolubyev added the good first issue Good for newcomers label Nov 25, 2019
@tsiq-karold
Copy link
Collaborator

Might be a good idea to find a way to convert any plugin config into webtau cfg so we don't have to keep adding fields to WebTauMavenRun (or the other one whose name escapes me).

@MykolaGolubyev
Copy link
Member Author

Would be nice for sure. From what I know about maven plugins is that you need to declare each field so xml validation take place. Or do you suggest to pass like a blob or something?

@tsiq-karold
Copy link
Collaborator

Not an expert on Maven plugins by any means but I think there is a way to just have a configuration node and get a hold of all child nodes. I don't know what it is though.

@MykolaGolubyev
Copy link
Member Author

@oneemo95 what is going on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@MykolaGolubyev @tsiq-karold and others