From e5e27b9939c1ff01d03b67285e39e1aed26020d9 Mon Sep 17 00:00:00 2001 From: juvester Date: Thu, 30 Jun 2016 11:40:10 +0300 Subject: [PATCH 1/3] Change error message --- src/main/java/fi/helsinki/cs/tmc/cli/tmcstuff/TmcUtil.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/main/java/fi/helsinki/cs/tmc/cli/tmcstuff/TmcUtil.java b/src/main/java/fi/helsinki/cs/tmc/cli/tmcstuff/TmcUtil.java index 7569f985..fdf0911f 100644 --- a/src/main/java/fi/helsinki/cs/tmc/cli/tmcstuff/TmcUtil.java +++ b/src/main/java/fi/helsinki/cs/tmc/cli/tmcstuff/TmcUtil.java @@ -205,7 +205,9 @@ protected static void handleTmcExceptions(CliContext ctx, Exception exception) { io.println("Your tmc-cli is outdated. Please update it."); return; } - io.println("Failed to connect to server."); + logger.error("Command failed in tmc-core", exception); + io.println("Command failed in tmc-core, check tmc-cli.log file for more info"); + //io.println("Failed to connect to server."); } private static boolean isAuthenticationError(Exception exception) { From 339c680ab180df6c8cd8f2163ab99dea121ac27e Mon Sep 17 00:00:00 2001 From: juvester Date: Thu, 30 Jun 2016 12:53:53 +0300 Subject: [PATCH 2/3] Stop submitting if one exercise fails --- .../fi/helsinki/cs/tmc/cli/command/SubmitCommand.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/main/java/fi/helsinki/cs/tmc/cli/command/SubmitCommand.java b/src/main/java/fi/helsinki/cs/tmc/cli/command/SubmitCommand.java index 6c9887a9..276918e9 100644 --- a/src/main/java/fi/helsinki/cs/tmc/cli/command/SubmitCommand.java +++ b/src/main/java/fi/helsinki/cs/tmc/cli/command/SubmitCommand.java @@ -108,8 +108,12 @@ public void run(CommandLine args, Io io) { SubmissionResult result = TmcUtil.submitExercise(ctx, exercise); if (result == null) { io.println("Submission failed."); - resultPrinter.addFailedExercise(); - continue; + if (!isOnlyExercise) { + io.println("Try to submit exercises one by one."); + } + return; + //resultPrinter.addFailedExercise(); + //continue; } resultPrinter.printSubmissionResult(result, isOnlyExercise); From 085b0c6131cb6faaa08470819cf71192bacfcd06 Mon Sep 17 00:00:00 2001 From: juvester Date: Thu, 30 Jun 2016 13:08:20 +0300 Subject: [PATCH 3/3] Remove comment --- src/main/java/fi/helsinki/cs/tmc/cli/tmcstuff/TmcUtil.java | 1 - 1 file changed, 1 deletion(-) diff --git a/src/main/java/fi/helsinki/cs/tmc/cli/tmcstuff/TmcUtil.java b/src/main/java/fi/helsinki/cs/tmc/cli/tmcstuff/TmcUtil.java index fdf0911f..c4eda7c8 100644 --- a/src/main/java/fi/helsinki/cs/tmc/cli/tmcstuff/TmcUtil.java +++ b/src/main/java/fi/helsinki/cs/tmc/cli/tmcstuff/TmcUtil.java @@ -207,7 +207,6 @@ protected static void handleTmcExceptions(CliContext ctx, Exception exception) { } logger.error("Command failed in tmc-core", exception); io.println("Command failed in tmc-core, check tmc-cli.log file for more info"); - //io.println("Failed to connect to server."); } private static boolean isAuthenticationError(Exception exception) {