This repository was archived by the owner on Jun 3, 2025. It is now read-only.
Some refactoring #381
Merged
Some refactoring #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
July 9, 2016 14:28
| private String getDeadline(Exercise exercise) { | ||
| String deadline = exercise.getDeadline(); | ||
| if (deadline == null) { | ||
| return "not available"; |
Contributor
Author
There was a problem hiding this comment.
I accidentally removed this if block
| private void printExerciseShort(Exercise exercise) { | ||
| io.println("Exercise: " + exercise.getName()); | ||
| io.println("Deadline: " + getDeadline(exercise)); | ||
| io.println("Deadline: " + exercise.getDeadlineDate()); |
Contributor
Author
There was a problem hiding this comment.
TODO
Check if DeadlineDate is null and print "none" if it is null.
And create unit test for it.
Contributor
Author
|
I don't mind if this pull request is merged to master. I will then just create new branch after my trip. |
Contributor
|
There is no rush to merge this massive refactoring yet, since it's not currently actively developed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small refactoring. ;-)
I will continue this work after about two weeks...