Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2734 keep the initial order of listeners #2737

Merged
merged 3 commits into from
Mar 16, 2022
Merged

#2734 keep the initial order of listeners #2737

merged 3 commits into from
Mar 16, 2022

Conversation

asolntsev
Copy link
Contributor

We need to run listeners at the same order in which they were declared in @listeners({First.class, Second.class, Third.class})

Fixes #2734 and #1219

Did you remember to?

  • Add test case(s)
  • Update CHANGES.txt
  • Auto applied styling via ./gradlew autostyleApply

@krmahadevan
Copy link
Member

@asolntsev - Thank you so much for taking the time to raise a PR. Can you please help add tests that will essentially vet out the changes for the defects that you linked?

@asolntsev
Copy link
Contributor Author

@krmahadevan Ugh... It was not easy, but I added the test: TestRunnerTest.java

We need to run listeners at the same order in which they were declared in @listeners({First.class, Second.class, Third.class})
@krmahadevan
Copy link
Member

@asolntsev - There are test failures. Please help take a look and help fix them.

@asolntsev
Copy link
Contributor Author

@krmahadevan I have fixed the tests.

I think the last CI failure is not caused by my changes. It seems to be some flaky test caused by concurrent tests run:

test.failedreporter.FailedReporterTest > tearDown failure marker
  Error:   0.0sec test.failedreporter.FailedReporterTest > tearDown
  java.nio.file.FileSystemException: C:\Users\RUNNER~1\AppData\Local\Temp\testng-tmp-2956855115414577614673\testng-failed.xml: The process cannot access the file because it is being used by another process.

@krmahadevan krmahadevan merged commit e9a6c4f into testng-team:master Mar 16, 2022
@krmahadevan
Copy link
Member

@asolntsev - Thank you so much for helping out with this PR. This now stands merged. Look forward to more such contributions

@asolntsev
Copy link
Contributor Author

Yes! Achievement unlocked :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Class Level Test Annotation does not allow the setting of priorrities for the methods
3 participants