From 0b988bec4651cdb7ebb73ab95585ba3c791c3dc8 Mon Sep 17 00:00:00 2001 From: PruthiviRaj27 <112844543+PruthiviRaj27@users.noreply.github.com> Date: Mon, 14 Aug 2023 17:13:53 +0530 Subject: [PATCH] fix: App crash when app name contains contain non-ASCII characters (#562) - We include the application name in the User-Agent request header to identify the app usage. If the app name includes special characters, it leads to a crash because the header value should not contain non-ASCII values. https://github.com/square/okhttp/issues/891 - In this commit, we have passed the package name to the User-Agent instead of the App name because the package name is also unique. --- core/src/main/java/in/testpress/util/UserAgentProvider.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/src/main/java/in/testpress/util/UserAgentProvider.java b/core/src/main/java/in/testpress/util/UserAgentProvider.java index 048ada68a..f497516ca 100644 --- a/core/src/main/java/in/testpress/util/UserAgentProvider.java +++ b/core/src/main/java/in/testpress/util/UserAgentProvider.java @@ -15,7 +15,7 @@ * * Example * - * testpress/1.1.2 (Dalvik; Android 9; Xiaomi POCO F1 Build/PKQ1.180729.001) okhttp + * in.testpress.samples/1.1.2 (Dalvik; Android 9; Xiaomi POCO F1 Build/PKQ1.180729.001) okhttp * */ public class UserAgentProvider { @@ -34,7 +34,7 @@ public static String get(Context context) { e.printStackTrace(); } userAgent = String.format("%s/%s (Dalvik; Android %s; %s %s Build/%s) okhttp", - context.getApplicationInfo().loadLabel(context.getPackageManager()), + context.getApplicationInfo().packageName, appVersion, Build.VERSION.RELEASE, Build.MANUFACTURER,