Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dockerfile and release GitHub Action #45

Merged

Conversation

yutachaos
Copy link
Contributor

Description

  • Added image build and push CI to GitHub Container Registry for use in containers

FYI

@fidian
Copy link
Contributor

fidian commented Apr 9, 2021

Is qemu used for the arm64 build? I'm curious because this is just written in shell code and I'm hoping you can tell me why I need a machine emulator.

@yutachaos yutachaos marked this pull request as ready for review April 9, 2021 23:21
@yutachaos
Copy link
Contributor Author

Is qemu used for the arm64 build? I'm curious because this is just written in shell code and I'm hoping you can tell me why I need a machine emulator.

I'm using your code in a container and want it to work on both arm cpu instances and amd cpu instances.

If you prepare images of both cpu with the function of Docker, you can automatically pull the image of the appropriate cpu, so both images are built.

@fidian
Copy link
Contributor

fidian commented Apr 17, 2021

Looks good to me.

@fidian fidian merged commit c86fd9a into tests-always-included:master Apr 17, 2021
@fidian
Copy link
Contributor

fidian commented Apr 17, 2021

Thanks for supplying this pull request!

@yutachaos
Copy link
Contributor Author

@fidian
Thank you for merging.

The docker build will run when the tag is created, so I'd be happy if you could create a new tag if possible. 🙏
https://github.com/tests-always-included/mo/pull/45/files#diff-e426ed45842837026e10e66af23d9c7077e89eacbe6958ce7cb991130ad05adaR14

@sugarshin
Copy link

@fidian could you please create a git-tag?

The docker build will run when the tag is created,

@fidian
Copy link
Contributor

fidian commented Nov 25, 2021

Sorry for the huge delay. I've just created the tag 2.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants