Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to pass "isInteraction" anim config #185

Merged
merged 3 commits into from Mar 24, 2019

Conversation

Projects
None yet
3 participants
@slorber
Copy link
Contributor

slorber commented Mar 5, 2019

By default RN animations are considered "interactions". This means during a dropdown alert animation, all InteractionManager.runAfterInteraction() callbacks will be suspended until animation completion.

This PR allows to set isInteraction=false from props and disable this behavior. In my usecase I'd like to avoid delaying the callbacks when a dropdown is animating.

This PR should be retrocompatible (isInteraction=true is default) for users and enable my usecase.

See also

slorber added some commits Mar 5, 2019

Allow user to pass "isInteraction" anim config
By default RN animations are considered "interactions". This means during a dropdown alert animation, all InteractionManager.runAfterInteraction() callbacks will be suspended until animation completion.

This PR allows to set isInteraction=false from props and disable this behavior. In my usecase I'd like to avoid delaying the callbacks when a dropdown is animating.

This PR should be retrocompatible (isInteraction=true is default) for users and enable my usecase.

See also 
- https://facebook.github.io/react-native/docs/animated#spring
- https://facebook.github.io/react-native/docs/interactionmanager
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 5, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@c449bee). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #185   +/-   ##
=========================================
  Coverage          ?   71.12%           
=========================================
  Files             ?       11           
  Lines             ?      187           
  Branches          ?        0           
=========================================
  Hits              ?      133           
  Misses            ?       54           
  Partials          ?        0
Impacted Files Coverage Δ
DropdownAlert.js 64.47% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c449bee...e15e32f. Read the comment docs.

@testshallpass testshallpass self-requested a review Mar 18, 2019

@testshallpass testshallpass merged commit 742a462 into testshallpass:master Mar 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.