Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put back useNativeDriver: true #186

Merged
merged 1 commit into from Mar 24, 2019

Conversation

Projects
None yet
3 participants
@slorber
Copy link
Contributor

slorber commented Mar 5, 2019

For me it's working fine on Android, are there reasons anymore to not make this the default?

Put back useNativeDriver: true
For me it's working fine on Android, are there reasons anymore to not make this the default?
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 5, 2019

Codecov Report

Merging #186 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #186   +/-   ##
=======================================
  Coverage   71.12%   71.12%           
=======================================
  Files          11       11           
  Lines         187      187           
=======================================
  Hits          133      133           
  Misses         54       54
Impacted Files Coverage Δ
DropdownAlert.js 64.47% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c8cd88...ade4f2e. Read the comment docs.

@testshallpass testshallpass self-requested a review Mar 18, 2019

@testshallpass

This comment has been minimized.

Copy link
Owner

testshallpass commented Mar 18, 2019

It was originally because it did not work great on earlier react-native version. What react-native version did you run it?

@slorber

This comment has been minimized.

Copy link
Contributor Author

slorber commented Mar 18, 2019

Expo SDK32 which should be RN 0.58 i think

@testshallpass testshallpass merged commit dad1171 into testshallpass:master Mar 24, 2019

2 checks passed

codecov/patch Coverage not affected when comparing 5c8cd88...ade4f2e
Details
codecov/project 71.12% remains the same compared to 5c8cd88
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.