Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

st-term magic byte via commandline argument #197

Merged
merged 1 commit into from Dec 11, 2013

Conversation

Projects
None yet
3 participants
Contributor

rene-dev commented Dec 11, 2013

The magic byte position can now be set via commandline argument.
nm can be used to find the position from the elf.
example: st-term arm-none-eabi-nm main.elf | grep stlinky_term | awk '{print $1}'

@prattmic prattmic commented on the diff Dec 11, 2013

src/st-term.c
@@ -39,7 +39,7 @@ struct stlinky* stlinky_detect(stlink_t* sl)
if (STLINKY_MAGIC == READ_UINT32_LE(sl->q_buf))
{
if (multiple > 0)
- printf("WARNING: another ");
+ printf("WARNING: another ");
@prattmic

prattmic Dec 11, 2013

Contributor

I assume this is a mistake? It makes it very easy to miss that the printf goes with the if statement.

@rene-dev

rene-dev Dec 11, 2013

Contributor

ah, it is. I did not see the if^^

@texane texane added a commit that referenced this pull request Dec 11, 2013

@texane texane Merge pull request #197 from rene-dev/master
st-term magic byte via commandline argument
411f7fa

@texane texane merged commit 411f7fa into texane:master Dec 11, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment