Conversation
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://tji-nextjs-git-autocomplete.evaruth.now.sh |
LayaTaal
left a comment
There was a problem hiding this comment.
I think this looks great @nholden! I really like how you handled this and the abstraction of the FilterContainer component.
Regarding your punts:
- Ignoring a filter group when all the individual options are unchecked.
- Agreed, going to make an issue for this.
- Setting up a polyfill for the element. At one point, was not well supported across browsers, but it looks like it's actually pretty well supported now. If we have specific browser versions we're targeting, we can revisit this.
- I went over our analytics right now and it looks like we have a fair number of users still on iOS 12.1.x versions (I didn't see any users in the last 6 months on 12.3, which seems strange to me). Aside from this browser, we are ok, but this may be something we want to consider indeed.
- Disabling native autofill on Safari. This seems to be a pain for lots of folks, and I'd be down to revisit this in a separate PR if we think this is a serious usability issue.
- Can you point me to an example of this? I'm not noticing anything on my desktop Safari. I also don't see very many users visiting from Safari on desktop, so it may not be worth addressing.
- Adding fake county data. I know that there's some ongoing work with our data formatting, so I didn't want to spend too much time creating fake data under our current assumptions.
- I think we are ok with what you've done. It looks like we should have the real data in the next few days.
|
Thanks for the review, @LayaTaal! 🙏✨
Oh, that's good to know! I wonder if we should pick the browsers that we're aiming to support and include them in the README. It might make it easier to decide when to use polyfills or explore other approaches. This reminded me that I noticed an issue with the filters on mobile, so I opened #66.
Sure! Here's what I see on Safari desktop. |

This PR adds a new autocomplete filter to the "explore the data" page that we can use for agencies and counties.
Things I punted on
<datalist>element. At one point,<datalist>was not well supported across browsers, but it looks like it's actually pretty well supported now. If we have specific browser versions we're targeting, we can revisit this.supports #3