Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process examples in deterministic order #181

Merged
merged 1 commit into from Apr 13, 2019

Conversation

bmwiedemann
Copy link
Contributor

@bmwiedemann bmwiedemann commented Apr 11, 2019

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly
  • Changelog(s) has/have been updated, as needed (see CHANGELOG.md).

Sort input file list
so that .pyc files in python-textX build in a reproducible way
in spite of indeterministic filesystem readdir order
and http://bugs.python.org/issue30461

See https://reproducible-builds.org/ for why this is good.

Might be related to https://bugs.python.org/issue34093

This PR was done while working on reproducible builds for openSUSE.

@goto40
Copy link
Member

goto40 commented Apr 11, 2019

Thank you for your investigation and for the patch. Looks good from my side.

Maybe you could just add a newline (but we can also do that for you!) - to make our code style checker happy again / see travis outcome; the line is too long).

Sort input file list
so that .pyc files in python-textX build in a reproducible way
in spite of indeterministic filesystem readdir order
and http://bugs.python.org/issue30461

See https://reproducible-builds.org/ for why this is good.

Might be related to https://bugs.python.org/issue34093
@bmwiedemann
Copy link
Contributor Author

Added a linebreak+indent to make flake8 happy. My local flake8 still complained about unsorted imports, but I guess you do not care.

@igordejanovic igordejanovic merged commit 779a830 into textX:master Apr 13, 2019
@igordejanovic
Copy link
Member

@bmwiedemann Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants