Update gemspec to allow Rails 4 support #25

Merged
merged 2 commits into from Feb 27, 2013

Conversation

Projects
None yet
2 participants

Quickly tested #advanced_search and #fuzzy_search and everything worked fine under the latest Rails 4 from rails/master

Used the same solution as haml-rails did recently.

benhamill was assigned Feb 18, 2013

Not bad. I want to play around with it, myself, a bit before I merge, but this is, in general, a good idea. Thanks.

Please do. I feel a bit weird submitting this without tests though. Is there a simple way to test against multiple Rails?

The only thing that springs to mind for me is to run the tests against different environments on a CI machine. Possibly we should look into that. I dunno.

It definitely would make sense to put the repo on Travis for good measure. :)

Draper shows good example on how to test against specific Rails versions and even Edge Rails, all of which seems to work beautifully with Travis.

You know what. Fuck it. 😉 Let's do it live. I'm merging this.

@benhamill benhamill added a commit that referenced this pull request Feb 27, 2013

@benhamill benhamill Merge pull request #25 from olivierlacan/rails4
Update gemspec to allow Rails 4 support
e6fb581

@benhamill benhamill merged commit e6fb581 into texticle:master Feb 27, 2013

Yay, thanks @benhamill 😸

Note: Textacular 3.0.0 is out. So you may want to switch to that. Where all
future development will go on. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment