Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages renaming & multiple fixes #172

Merged
merged 11 commits into from Mar 9, 2020
Merged

Packages renaming & multiple fixes #172

merged 11 commits into from Mar 9, 2020

Conversation

@jsign
Copy link
Contributor

jsign commented Mar 9, 2020

  • Renames FPA to FFS.
  • Renames FastAPI to API with api as shorthand.
  • Rename repo to Powergate
    • Repo name changed from .texfc to .powergate
    • Binaries changed from fil-tools(d) to pow(d)
    • Env var prefix changed from TEXFILTOOLS_ to TEXPOWERGATE_
  • Closes #169
  • Closes #170
  • Closes #171
  • Closes #173
jsign added 9 commits Mar 8, 2020
fpa/scheduler: simplify assignement

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
renamings
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
mod tidy
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
pr tidy
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
@jsign jsign self-assigned this Mar 9, 2020
@jsign jsign marked this pull request as ready for review Mar 9, 2020
@jsign jsign requested review from asutula and sanderpick Mar 9, 2020
jsign added 2 commits Mar 9, 2020
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
@jsign jsign added this to the Sprint 32 milestone Mar 9, 2020
@asutula

This comment has been minimized.

Copy link
Member

asutula commented Mar 9, 2020

There are some actual bug fixes and/or improvements in here, right? Can you point those out with a few comments just to make sure they don't get lost in the naming refactor changes?

Copy link
Member

sanderpick left a comment

Gave it a slow scroll through.... LGTM! 💪 Behold the Powergate 💪

repoPath := config.GetString("repopath")
if repoPath == "${HOME}/.texfc" {
home, err := os.UserHomeDir()
repoPath = config.GetString("repopath")
if repoPath == "~/.powergate" {
expandedPath, err := homedir.Expand(repoPath)
if err != nil {
log.Fatalf("error when setting default repo path to home dir: %s", err)
log.Fatalf("expanding homedir: %s", err)
}
repoPath = strings.Replace(repoPath, "${HOME}", home, -1)
repoPath = expandedPath
}
} else {
Comment on lines -68 to 76

This comment has been minimized.

Copy link
@jsign

jsign Mar 9, 2020

Author Contributor

Use of go-homedir

s.lock.Lock()
s.index = index
s.lock.Unlock()
Comment on lines +196 to +198

This comment has been minimized.

Copy link
@jsign

jsign Mar 9, 2020

Author Contributor

Save partial progress.

@@ -1,4 +1,4 @@
FROM golang:1.13.7 as builder
FROM golang:1.14 as builder

This comment has been minimized.

Copy link
@jsign

jsign Mar 9, 2020

Author Contributor

Bump to 1.14

@jsign

This comment has been minimized.

Copy link
Contributor Author

jsign commented Mar 9, 2020

@asutula , I left some extra comments about the fixes.
I'll merge just to unblock @andrewxhill , but feel free to take a look and I'll address if something pops up.

@jsign jsign merged commit 8ee45a2 into master Mar 9, 2020
2 checks passed
2 checks passed
Test
Details
DCO DCO
Details
@jsign jsign deleted the jsign/fastapi3 branch Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.