Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Node.js 4.x support #443

Closed
azu opened this issue Dec 31, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@azu
Copy link
Member

commented Dec 31, 2017

image

nodejs/Release: Node.js Foundation Release Working Group

Node.js 4.x is already Maintaince mode.
Node.js 4.x will be EOL at April 2018.

We will drop Node.js 4.x support in near future.

This issue track Node.js 4.x support.

Plan

This means that dropped testing in Node.js v4.
Code base is not udpated.
(textlint work on Node.js v4 for a little while)

@0x6b

This comment has been minimized.

Copy link
Member

commented Jan 3, 2018

@azu, I have no problem about dropping old Node versions according to their maintenance schedule. But I think not all of textlint users are Node.js programmer—they have been just using Node.js for textlint—so they might not aware of Node.js release cycle. It'd be good for such users to get end of support date as early as possible to prevent their daily workflow running under unsupported version. My quick thoughts include:

  • Update README and textlint.github.io to announce v4 end of support
  • Update textlint cli to warn end of support date

I think I'm thinking too much 😟 (or too enterprisey?) Your comments would be appreciated.

@azu

This comment has been minimized.

Copy link
Member Author

commented Jan 6, 2018

But I think not all of textlint users are Node.js programmer

Yes.
Main purpose of this issue is that drop Node.js v4 from .travis.yml.
Of course, To show warning is helpful for user.
(engines field of pacakge.json is helpful)
Because, Some rule has required Node.js >=6 like textlint-rule-no-dead-link.

Update README and textlint.github.io to announce v4 end of support

Yeah, We can improve Install(requirements) section on https://github.com/textlint/textlint#installation

Update textlint cli to warn end of support date

We are careful about that implementation.
Because, textlint's stdout is used by other CLI.

For example, some user use textlint as follows:

# unix pipe
textlint -f json | jq "."

Some editor integration use this pattern: https://github.com/textlint/textlint#editors

Probably, we should add meta data like { name: "stylish", forMachine: false } to getFormatterList() and getFixerFormatterList() before to show warning.

@azu

This comment has been minimized.

Copy link
Member Author

commented May 18, 2018

I've removed Node.js 4 from Travis CI.
Because, it block CI..
0c49f0b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.