Closing } do not have correct scope. #5

Merged
merged 1 commit into from Feb 28, 2012

Projects

None yet

2 participants

Contributor

I may be wrong but when using the Solorized theme I noticed that opening and closing {} were not highlighted the same. This of course may be intentional but it annoyed me and in the process of figuring out how to change it I discovered that closing } do not have a scope applied to them - thus they are highlighted as an invalid character.

Adding the ( ) around the 'end' regex seems to allow the endCaptures to capture the } and apply the punctuation.section.property-list.css scope correctly and now both { and } and sytax highlighted the same way.

@Binarytales Binarytales I may be wrong but when using the Solorized theme I noticed that open…
…ing and closing {} were not highlighted the same. This of course may be intentional but it annoyed me and in the process of figuring out how to change it I discovered that the closing } did not have a scope applied to it - thus it was being highlighted as an invalid character.


Anyway. Add the () around the end regex seems to allow the endCaptures to capture the } and apply the punctuation.section.property-list.css scope correctly and now both { and } and sytax highlighted the same way.
e330df0
Member

The CSS bundle and others will be maintained under the Avian/CSS.tmbundle for tm2+.
I did a massive rewrite a while back that may be merged in or maybe it'll get a brand new implementation. Either way, I'll pull this change here. Thanks for the PR!

@subtleGradient subtleGradient merged commit 8b51957 into textmate:master Feb 28, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment