Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
branch: master

Sep 23, 2013

  1. Michael Sheets

    Ignore non-empty multiline strings in next/previous macros

    Fixes #2, thanks to Martin Häcker. Also add support for plural forms of `msgstr`.
    infininight authored
  2. Michael Sheets

    Simplify flag match

    #ignore
    infininight authored
  3. Michael Sheets

    Revamp item matches in grammar

    Cleanup scoping and support multi-line comments, fixes #1. Support more than one file reference in `comment.line.number-sign.reference`.
    infininight authored
  4. Michael Sheets

    Don't mark empty lines as invalid

    infininight authored
  5. Michael Sheets

    Add match for obsolete entries

    infininight authored
  6. Michael Sheets

    Cleanup comment types and scopes

    infininight authored
  7. Michael Sheets

    Revise and extend header scopes

    infininight authored
  8. Michael Sheets

    Allow headers only at the start of a document

    infininight authored

Nov 14, 2011

  1. Michael Sheets

    Move folding settings.

    infininight authored
  2. Michael Sheets

    Add readme.

    infininight authored

Oct 19, 2007

  1. Allan Odgaard

    • use TM_FULLNAME instead of TM_USERNAME in all templates and remove …

    …the setup of TM_USERNAME from the template script/helper
    
    git-svn-id: http://svn.textmate.org/trunk/Bundles/Gettext.tmbundle@8306 dfb7d73b-c2ec-0310-8fea-fb051d288c6d
    sorbits authored

Jun 28, 2007

  1. Allan Odgaard

    • move bundle out of Review

    git-svn-id: http://svn.textmate.org/trunk/Bundles/Gettext.tmbundle@7618 dfb7d73b-c2ec-0310-8fea-fb051d288c6d
    sorbits authored

Jun 21, 2007

  1. Revised regexp for syntax highlighting of flag comments

    git-svn-id: http://svn.textmate.org/trunk/Review/Bundles/Gettext.tmbundle@7561 dfb7d73b-c2ec-0310-8fea-fb051d288c6d
    Lawrence Akka authored
  2. Renaming directory for consistency with change of name of template. H…

    …ave to operate directly on repository, because svn on OSX cannot make a change where the only change is a change of case
    
    git-svn-id: http://svn.textmate.org/trunk/Review/Bundles/Gettext.tmbundle@7560 dfb7d73b-c2ec-0310-8fea-fb051d288c6d
    Lawrence Akka authored
  3. Title case PO template file

    git-svn-id: http://svn.textmate.org/trunk/Review/Bundles/Gettext.tmbundle@7558 dfb7d73b-c2ec-0310-8fea-fb051d288c6d
    Lawrence Akka authored

Jun 15, 2007

  1. Better description in info.plist

    git-svn-id: http://svn.textmate.org/trunk/Review/Bundles/Gettext.tmbundle@7533 dfb7d73b-c2ec-0310-8fea-fb051d288c6d
    Lawrence Akka authored
  2. Revised keybindings - previous bindings eclipsed Navigation → Go to H…

    …eader/Source
    
    git-svn-id: http://svn.textmate.org/trunk/Review/Bundles/Gettext.tmbundle@7532 dfb7d73b-c2ec-0310-8fea-fb051d288c6d
    Lawrence Akka authored
  3. msgid and msgstr menu items renamed as Message ID and Message String.

    Reordering menu items, and using a separator. 
    
    
    git-svn-id: http://svn.textmate.org/trunk/Review/Bundles/Gettext.tmbundle@7531 dfb7d73b-c2ec-0310-8fea-fb051d288c6d
    Lawrence Akka authored
  4. Implementing some changes as per review comments

    git-svn-id: http://svn.textmate.org/trunk/Review/Bundles/Gettext.tmbundle@7530 dfb7d73b-c2ec-0310-8fea-fb051d288c6d
    Lawrence Akka authored

Jun 11, 2007

  1. Allan Odgaard

    # Abstract

    These are review comments for the Gettext bundle submitted by Lawrence Akka.
    
    Review comments should generally be anal, since half the idea with a public review process is to have other bundle developers also take note of the comments (and apply it to their bundles).
    
    
    # Menu Structure
    
    ## Consistent Use of Title Case
    
    The `msgid` and `msgstr` could be written out as `Message ID` and `Message String`. Considering how few items are in the menu, and how the other items are title cased, I would suggest such a change.
    
    
    ## Appropriate Use of Submenus
    
    With only four items, there is no need for submenus.
    
    
    ## Good Use of Separators
    
    The menu has two very different types of items (one set is move actions, the other set is “insert boilerplate” actions) yet no separator -- the two sets of actions should be separated.
    
    
    ## Good Logical Ordering of Items
    
    Generally put actions (such as the move items) before items which insert boilerplate (i.e. snippets).
    
    The main reason for this rule is that we generally have far fewer actions than snippets, and thus we want to start with these (i.e. place them at the top) so that they are not overlooked.
    
    
    # Activation
    
    ## Proper Use of Scope Selectors for All Items
    
    All items has the proper scope selector, good! :)
    
    
    ## Proper Adherence to Key Equivalent Conventions
    
    The “Previous Untranslated” does eclipse Navigation → Go to Header/Source. I don’t think it is entirely unlikely that you may have `my_shell_command.cc` and `my_shell_command.po`, and thus want to use ⌥⌘↑ to switch between the two.
    
    So I would recommend changing the keys to ⌃⇧↓ / ⌃⇧↑ (⌃⇧ are the designated _bundle item modifiers_).
    
    
    # Language Grammar
    
    ## Using Only Valid Scopes
    
    The bundle passes `Support/bin/validate_bundle.rb` -- so good job!
    
    
    ## Using Grammar Name As Suffix for All Declared Scopes
    
    It prefixes all scopes with `po` and the grammar itself is `source.po` so this is good. Though I must add that `po` is a very short name -- what is it short for?
    
    
    ## Using Punctuation Scopes
    
    The grammar does not use punctuation scopes, but then, I don’t really balme it ;)
    
    
    # Bundle
    
    ## Understandable Naming of Items
    
    The template should definitely be renamed from `PO file`. First, it is not title cased, second, it makes very little sense (it helps that it is in a Gettext submenu, but still).
    
    
    ## Contact Info in `info.plist`
    
    Is there, good!
    
    
    ## Good Description in `info.plist`
    
    I think we can elaborate on _is used for localising (sic) software_. For example what type of software? Is this system POSIX or similar?
    
    
    ## All UUID’s Are Unique
    
    Passes that one as well.
    
    
    git-svn-id: http://svn.textmate.org/trunk/Review/Bundles/Gettext.tmbundle@7502 dfb7d73b-c2ec-0310-8fea-fb051d288c6d
    sorbits authored
  2. Allan Odgaard

    • Gettext bundle from Lawrence Akka — review comments to follow.

    git-svn-id: http://svn.textmate.org/trunk/Review/Bundles/Gettext.tmbundle@7501 dfb7d73b-c2ec-0310-8fea-fb051d288c6d
    sorbits authored
Something went wrong with that request. Please try again.